Skip to content

Conversation

@amueller
Copy link
Contributor

@amueller amueller commented Feb 6, 2018

Didn't add a test... but tests are failing anyway? What's up with that?

@amueller
Copy link
Contributor Author

amueller commented Feb 6, 2018

part of #75

@mfeurer
Copy link
Collaborator

mfeurer commented Feb 7, 2018

I think tests on the development branch fail in general right now.

@joaquinvanschoren
Copy link
Contributor

joaquinvanschoren commented Feb 7, 2018 via email

@mfeurer
Copy link
Collaborator

mfeurer commented Feb 8, 2018

This dataset is one of the culprits. @janvanrijn will fix issues with the test server within the next few days.

@codecov-io
Copy link

codecov-io commented Feb 19, 2018

Codecov Report

Merging #391 into develop will decrease coverage by 0.15%.
The diff coverage is 37.5%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #391      +/-   ##
===========================================
- Coverage    89.53%   89.37%   -0.16%     
===========================================
  Files           32       32              
  Lines         2676     2683       +7     
===========================================
+ Hits          2396     2398       +2     
- Misses         280      285       +5
Impacted Files Coverage Δ
openml/runs/run.py 90.71% <37.5%> (-1.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2513667...e090d36. Read the comment docs.

@mfeurer mfeurer merged commit 5058e1d into openml:develop Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants