String feature supports, use pandas dataframes #363
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This looks very promising. Can I somehow help here with comments etc? |
Contributor
Author
|
Ugh, I forgot this wasn't done yet. Ping me? Take over? hrm... |
Collaborator
|
I don't think anyone if Freiburg has capacities to take this over at the moment. I'm afraid it has to wait some time... |
8 tasks
Contributor
|
Hi all. Gael just reminded me that this is still open. Do we have some bandwidth now to look at this? |
Collaborator
|
@glemaitre was working on this in #548 and wanted to continue on this, too. |
Collaborator
|
Should be superseded by #548. Please reopen if this is not the case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft of adding string feature support via using pandas dataframes. I think using pandas would be nice to handle even float vs categorical etc. But that makes a lot of tests fail, in particular on dtypes.
After this change, columns can have very different dtypes. For example all null columns now have object dtype. Do we want to leave it like that?