Skip to content

Cast data qualities to float #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
amueller merged 1 commit into from
Oct 12, 2017
Merged

Cast data qualities to float #353

amueller merged 1 commit into from
Oct 12, 2017

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Oct 12, 2017 •
edited
Loading

Fixes #345.

@mfeurer mfeurer requested a review from amueller October 12, 2017 12:14
@mfeurer mfeurer mentioned this pull request Oct 12, 2017
Closed
@codecov-io
Copy link

codecov-io commented Oct 12, 2017 •
edited
Loading

Codecov Report

Merging #353 into develop will increase coverage by 0.21%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #353      +/-   ##
==========================================
+ Coverage    89.69%   89.9%   +0.21%     
==========================================
  Files           32      32              
  Lines         2522    2626     +104     
==========================================
+ Hits          2262    2361      +99     
- Misses         260     265       +5
Impacted Files Coverage Δ
openml/datasets/functions.py 91.52% <100%> (+1.47%) ⬆️
openml/datasets/dataset.py 79.57% <100%> (+0.71%) ⬆️
openml/tasks/functions.py 87.55% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e01ef40...aa758f9. Read the comment docs.

@amueller
Copy link
Contributor

amueller commented Oct 12, 2017

I'd argue the xsd is wrong? Semantically they are not floats, right?

@amueller
Copy link
Contributor

amueller commented Oct 12, 2017

I'd say this is better then before but still kinda stupid ;)

@mfeurer
Copy link
Collaborator Author

mfeurer commented Oct 12, 2017

Some qualities are floats, but some aren't. And except for writing down which to cast as int I wouldn't how to do this.

@amueller amueller merged commit 6b22bb6 into develop Oct 12, 2017
@mfeurer mfeurer deleted the fix_345 branch October 15, 2017 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amueller amueller amueller approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mfeurer @codecov-io @amueller