Skip to content

Conversation

@toon-vc
Copy link
Contributor

@toon-vc toon-vc commented Oct 11, 2017

My second attempt to add the clustering unit test. If this is successful, I will close the other pull request and remove the 'clustering' branch.

@codecov-io
Copy link

codecov-io commented Oct 11, 2017

Codecov Report

Merging #348 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #348   +/-   ##
========================================
  Coverage    89.69%   89.69%           
========================================
  Files           32       32           
  Lines         2522     2522           
========================================
  Hits          2262     2262           
  Misses         260      260

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9664a0f...da5bb80. Read the comment docs.

Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you may want to add a pipeline unit test, too?

@mfeurer mfeurer merged commit bd3a12b into develop Oct 12, 2017
@mfeurer mfeurer deleted the clust branch October 12, 2017 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants