Skip to content

Conversation

@janvanrijn
Copy link
Member

@mfeurer I am really wondering what you think of the implementation. There is no hurry with this feature

@mfeurer
Copy link
Collaborator

mfeurer commented Aug 26, 2017

Hey, I'd be interested in the rational behind this before actually looking at the implementation.

@janvanrijn
Copy link
Member Author

Sklearn has for most hyperparameters some pretty good defaults, which can be a topic of research (e.g., answering the question, how much better are we than the default hyperparameter configuration). This function allows to reinitialize an OpenML flow with these defaults.

The difficulty lies in hyperparameters that do not have any defaults (e.g., the steps of a pipeline). These need to be inferred from the flowname.

@mfeurer
Copy link
Collaborator

mfeurer commented Aug 28, 2017

Okay, so instead of creating the flow via a pipeline with the appropriate hyperparameter configuration, you want to download an existing flow and alter its hyperparameter configuration?

@mfeurer
Copy link
Collaborator

mfeurer commented Jun 18, 2018

Really interesting. If you resolve the merge conflict and update the documentation, I think we can merge this.

@janvanrijn
Copy link
Member Author

Thanks for checking this.

I predict that it will work after my most recent commit.

update the documentation

The undocumented part of the function is the 'components' part in kwargs. TBH I have no clue what this does again, and what the rationale is (this function was undocumented before). Can you add it?

@janvanrijn janvanrijn requested a review from mfeurer June 18, 2018 18:40
@codecov-io
Copy link

codecov-io commented Jun 18, 2018

Codecov Report

Merging #300 into develop will increase coverage by 0.02%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #300      +/-   ##
===========================================
+ Coverage    89.46%   89.48%   +0.02%     
===========================================
  Files           32       32              
  Lines         2771     2786      +15     
===========================================
+ Hits          2479     2493      +14     
- Misses         292      293       +1
Impacted Files Coverage Δ
openml/flows/sklearn_converter.py 92.2% <88.88%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4603345...bb99ec3. Read the comment docs.

@joaquinvanschoren joaquinvanschoren self-requested a review June 18, 2018 22:23
@mfeurer mfeurer merged commit 666d4c7 into develop Jun 19, 2018
@mfeurer mfeurer deleted the init_default_flows branch June 19, 2018 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants