Skip to content

Conversation

@PGijsbers
Copy link
Collaborator

@PGijsbers PGijsbers commented Jun 18, 2025

Idea on how to configure the usage of the server in one place.
Problem is that it still doesn't really work with the existing unittest cases which also execute their own setup/teardown.
... or we also modify the setup/teardown to avoid setting server configuration. brb.

@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.71%. Comparing base (5be0d24) to head (91f3d52).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #1411       +/-   ##
============================================
- Coverage    83.15%   53.71%   -29.44%     
============================================
  Files           38       38               
  Lines         5231     5229        -2     
============================================
- Hits          4350     2809     -1541     
- Misses         881     2420     +1539     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PGijsbers PGijsbers force-pushed the prod-mark-is-prod-test branch 4 times, most recently from 96de9c5 to f65ee2b Compare June 18, 2025 09:19
@PGijsbers PGijsbers force-pushed the prod-mark-is-prod-test branch from f65ee2b to 32b1320 Compare June 18, 2025 09:24
@PGijsbers PGijsbers force-pushed the prod-mark-is-prod-test branch 2 times, most recently from d0e71d2 to 37a31fb Compare June 18, 2025 10:09
@PGijsbers PGijsbers force-pushed the prod-mark-is-prod-test branch from 37a31fb to 44c2bd5 Compare June 18, 2025 12:49
@PGijsbers PGijsbers marked this pull request as ready for review June 18, 2025 13:22
@PGijsbers
Copy link
Collaborator Author

Copy link
Contributor

@LennartPurucker LennartPurucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor

@LennartPurucker LennartPurucker merged commit 94116e7 into develop Jun 18, 2025
1 check passed
@LennartPurucker LennartPurucker deleted the prod-mark-is-prod-test branch June 18, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants