-
-
Notifications
You must be signed in to change notification settings - Fork 211
Automatically connect to production server based on mark #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1411 +/- ##
============================================
- Coverage 83.15% 53.71% -29.44%
============================================
Files 38 38
Lines 5231 5229 -2
============================================
- Hits 4350 2809 -1541
- Misses 881 2420 +1539 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
96de9c5 to
f65ee2b
Compare
f65ee2b to
32b1320
Compare
d0e71d2 to
37a31fb
Compare
37a31fb to
44c2bd5
Compare
PGijsbers
commented
Jun 18, 2025
PGijsbers
commented
Jun 18, 2025
Collaborator
Author
LennartPurucker
requested changes
Jun 18, 2025
Contributor
LennartPurucker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor
LennartPurucker
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea on how to configure the usage of the server in one place.
Problem is that it still doesn't really work with the existingunittestcases which also execute their own setup/teardown.... or we also modify the setup/teardown to avoid setting server configuration. brb.