Add/1034 #1352
Merged
Add/1034 #1352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PGijsbers
commented
Sep 19, 2024
PGijsbers
commented
Sep 19, 2024
PGijsbers
commented
Sep 19, 2024
PGijsbers
commented
Sep 19, 2024
PGijsbers
commented
Sep 19, 2024
PGijsbers
commented
Sep 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1352 +/- ##
===========================================
- Coverage 84.33% 84.28% -0.06%
===========================================
Files 38 38
Lines 5293 5288 -5
===========================================
- Hits 4464 4457 -7
- Misses 829 831 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PGijsbers
commented
Sep 19, 2024
LennartPurucker
approved these changes
Sep 22, 2024
Contributor
LennartPurucker
left a comment
LennartPurucker
left a comment
There was a problem hiding this comment.
LGTM; very nice refactor of the tests!
Otherwise, no further comments from my side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn on lazy loading by default for datasets.
Leaving tasks for a separate PR as I notice the diff is getting big since I made some additional changes to the tests.
So only progress for #1034.
I couldn't clean up everything, but I tried to clean things up a little bit.
The use of parametrize required me to work outside of the unittest class.
I tried to still make behavior similar as possible so its easier that they're not doing wildly different things (I do think that a lot of the setup/teardown that come with the general behavior isn't really needed though).