Fix/1349 #1350
Merged
Fix/1349 #1350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1350 +/- ##
===========================================
+ Coverage 83.88% 84.14% +0.26%
===========================================
Files 38 38
Lines 5261 5260 -1
===========================================
+ Hits 4413 4426 +13
+ Misses 848 834 -14 ☔ View full report in Codecov by Sentry. |
Collaborator
Author
|
There are unfortunately minor server issues after all. They didn't happen earlier in the week in a local test, currently don't have the internet connection bandwidth to track it down (travelling). But looking at the failures, they can't be related to the PR. |
eddiebergman
approved these changes
Sep 16, 2024
Collaborator
|
Not super familiar with this domain of Python but from a quick read it seems mostly superficial in terms of changes and didn't spot anything off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1349
Distutils is removed in Py3.12, so we have to rely on external packages.
packagingis already a dependency of one of our dependencies, so it doesn't add to the stack (though I made it implicit, in case the dependency chain gets broken at some point for some reason).