Only download arff if required #1346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1346 +/- ##
===========================================
+ Coverage 83.88% 84.19% +0.31%
===========================================
Files 38 38
Lines 5261 5271 +10
===========================================
+ Hits 4413 4438 +25
+ Misses 848 833 -15 ☔ View full report in Codecov by Sentry. |
LennartPurucker
approved these changes
Sep 13, 2024
Contributor
LennartPurucker
left a comment
LennartPurucker
left a comment
There was a problem hiding this comment.
LGTM, I only have one question.
I am unsure about the tests, but I trust that you know best how reliable they are right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress in #1032. I think it's mostly there but I need a little time to think it over and see how well this is covered by the test server, since there mostly are not parquet files available.
edit: added a check to an existing test which I think covers it well enough. Especially since we need to update/rewrite some of the tests with lazy loading being on by default. This I will do in a separate PR.