Skip to content

Conversation

@PGijsbers
Copy link
Collaborator

No longer needed since we have pre-commit.ci active. I suppose the latter only works on the delta and not all files, but that should not be an issue.

@PGijsbers PGijsbers added the maintenance & CI Continuous integration & package distribution label Jul 10, 2024
@PGijsbers PGijsbers requested a review from eddiebergman July 10, 2024 08:26
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (e4e6f50) to head (a38022e).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1343      +/-   ##
===========================================
- Coverage    83.88%   83.82%   -0.06%     
===========================================
  Files           38       38              
  Lines         5261     5261              
===========================================
- Hits          4413     4410       -3     
- Misses         848      851       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddiebergman
Copy link
Collaborator

I've never used the standalone github plugin. Looks pretty good in terms of speed, probably better than a naive setup through github actions. Fire ahead!

One caveat to consider is that if you ever want to consider pre-commit as a requirement before a release, i.e. in an automated fashion, you may need to re-introduce that it runs through github actions somewhere

@PGijsbers
Copy link
Collaborator Author

It's definitely faster, often finishes before the GHA job is even set up.
I do think the concern is valid, but I think that would be clearer to do that in whatever dedicated release pipeline we build and not as a standalone workflow anyway.

@PGijsbers PGijsbers merged commit de983ac into develop Jul 10, 2024
@PGijsbers PGijsbers deleted the ci/remove-pre-commit branch July 10, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance & CI Continuous integration & package distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants