Refactor if-statements #1219
Merged
Refactor if-statements #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfeurer
reviewed
Feb 24, 2023
| return False | ||
| else: | ||
| return ( | ||
| return (isinstance(flow.dependencies, str) and "sklearn" in flow.dependencies) or ( |
Collaborator
There was a problem hiding this comment.
I understand the change away from getattr, but I'm not sure if the overall outcome is more readable.
Contributor
There was a problem hiding this comment.
I think this also results in a crash for windows, as the Dummyflow does not have this attribute: https://github.com/openml/openml-python/actions/runs/4261463411/jobs/7415818507#step:9:792
Must every flow have this attribute, or why was getattr used in the first place?
Collaborator
Author
There was a problem hiding this comment.
Yes. DummyFlow is not actually an OpenMLFlow object, which is why it crashes:
class DummyFlow:
external_version = "DummyFlow==0.1"But flow.dependencies is set on __init__ so any proper OpenMLFlow has the attribute. I added dependencies to DummyFlow now so it better mimics an OpenMLFlow.
Collaborator
Author
There was a problem hiding this comment.
Refactored the method by first explicitly assigning the individual expressions to a variable. Of course we lose short-cutting the or, but that shouldn't ever matter.
LennartPurucker
approved these changes
Feb 27, 2023
mfeurer
approved these changes
Mar 1, 2023
mfeurer
added a commit
that referenced
this pull request
Mar 1, 2023
* added additional task agnostic local result to print of run * add PR to progress.rst * fix comment typo * Update openml/runs/run.py Co-authored-by: Matthias Feurer <[email protected]> * add a function to list available estimation procedures * refactor print to only work for supported task types and local measures * add test for pint out and update progress * added additional task agnostic local result to print of run * add PR to progress.rst * fix comment typo * Update openml/runs/run.py Co-authored-by: Matthias Feurer <[email protected]> * add a function to list available estimation procedures * refactor print to only work for supported task types and local measures * add test for pint out and update progress * Fix CI Python 3.6 (#1218) * Try Ubunte 20.04 for Python 3.6 * use old ubuntu for python 3.6 * Bump docker/setup-buildx-action from 1 to 2 (#1221) Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 1 to 2. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v1...v2) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update run.py (#1194) * Update run.py * Update run.py updated description to not contain duplicate information. * Update run.py * add type hint for new function * update add description * Refactor if-statements (#1219) * Refactor if-statements * Add explicit names to conditional expression * Add 'dependencies' to better mimic OpenMLFlow * Ci python 38 (#1220) * Install custom numpy version for specific combination of Python3.8 and numpy * Debug output * Change syntax * move to coverage action v3 * Remove test output * added additional task agnostic local result to print of run * add PR to progress.rst * fix comment typo * Update openml/runs/run.py Co-authored-by: Matthias Feurer <[email protected]> * add a function to list available estimation procedures * refactor print to only work for supported task types and local measures * add test for pint out and update progress * added additional task agnostic local result to print of run * add PR to progress.rst * add type hint for new function * update add description * fix run doc string --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Matthias Feurer <[email protected]> Co-authored-by: Matthias Feurer <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Vishal Parmar <[email protected]> Co-authored-by: Pieter Gijsbers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.