Add summary of locally computed metrics to representation of run #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfeurer
reviewed
Feb 22, 2023
Co-authored-by: Matthias Feurer <[email protected]>
Co-authored-by: Matthias Feurer <[email protected]>
…o run_print # Conflicts: # doc/progress.rst
* Try Ubunte 20.04 for Python 3.6 * use old ubuntu for python 3.6
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 1 to 2. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v1...v2) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update run.py * Update run.py updated description to not contain duplicate information. * Update run.py
mfeurer
reviewed
Feb 24, 2023
* Refactor if-statements * Add explicit names to conditional expression * Add 'dependencies' to better mimic OpenMLFlow
* Install custom numpy version for specific combination of Python3.8 and numpy * Debug output * Change syntax * move to coverage action v3 * Remove test output
Collaborator
|
Before merging this, could you please have a look at the pre-commit? That one is currently failing. |
Co-authored-by: Matthias Feurer <[email protected]>
Contributor
Author
|
I fixed the doc string for the run that was malformed as a result of another PR. The pre-commit should work now. |
mfeurer
approved these changes
Mar 1, 2023
Collaborator
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
Since the remaining failures are due to the test server this looks ready to merge for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #1144 and might be a solution for the issue.
It is important to note that the representation already included a "Result" field and thus could have reported results in the printout. However, this only happens if the
evaluationof the run is filled.This implementation now also covers locally computed results. The locally computed results are only shown if no task/run-specific results already exist.
Example
Old Output:
New Output (ignore the difference in
Setup String):Test
I am not sure if we need to write a test for this. I did not find any tests for the representation so far.