fix nonetype error during print for tasks without class labels #1148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfeurer
approved these changes
Oct 6, 2022
Collaborator
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
This looks good to me. @PGijsbers since you created the original issue, would you be happy with this fix?
Collaborator
|
Yep! Sorry for the late response @willcmartin, but the contribution is much appreciated 🎉 |
PGijsbers
added a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
…l#1148) * fix nonetype error during print for tasks without class labels * fix openml#1100/openml#1058 nonetype error Co-authored-by: Pieter Gijsbers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Fixes #1100 and #1058
What does this PR implement/fix? Explain your changes.
Previously, if
class_labelsattribute of task isNonewhen__repr__was called, aNoneTypeerror was thrown. Now "# of Classes" is not printed if there are noclass_labels.How should this PR be tested?
Any other comments?
I followed the implementation suggestion from #1100 where "# of Classes" is ignored. Let me know if this is no longer the best solution to this issue.