Precommit update #1129
Merged
Precommit update #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfeurer
approved these changes
Apr 14, 2022
PGijsbers
added a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
* Correctly use regex to specify files * Add type hint * Add note of fixing pre-commit hook openml#1129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Closes #1030
What does this PR implement/fix? Explain your changes.
The pre-commit hooks were configured incorrectly.
I don't think this led to incorrect behavior, but it did give warnings.
It also adds a type cast for one mypy error that somehow made it into the codebase.
How should this PR be tested?
When running
pre-commit run --all-filesit should pass without fail or warning (it does not indevelop).Any other comments?