Always ignore MaxRetryError but log with warning #1119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently parquet files are completely optional, so under no circumstance should the inability to download it raise an error to the user. Instead we log a warning and proceed without the parquet file.
mfeurer
reviewed
Oct 27, 2021
Collaborator
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
I'm not sure if I understand the changes correctly. Moving the MaxRetryError is just to have all error handling in one place, right? So effectively, this PR adds a log message?
Collaborator
Author
|
And because error handling is now in one place, this call which was previously unguarded becomes guarded too. This previous asymmetry (catching it in one place but not the other) lead to the odd different behavior described in #1116 where: dataset = openml.datasets.get_dataset(554, download_data=False)
X, y, is_categorical, _ = dataset.get_data(
dataset_format="array", target=dataset.default_target_attribute
)gave an error but dataset = openml.datasets.get_dataset(554)
X, y, is_categorical, _ = dataset.get_data(
dataset_format="array", target=dataset.default_target_attribute
)did not. |
mfeurer
approved these changes
Oct 27, 2021
Collaborator
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
Ah, I didn't see that other call, sorry.
PGijsbers
added a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
Currently parquet files are completely optional, so under no circumstance should the inability to download it raise an error to the user. Instead we log a warning and proceed without the parquet file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently parquet files are completely optional, so under no circumstance should the inability to download it raise an error to the user. Instead we log a warning and proceed without the parquet file.
Note that while in the code diff the change might seem ineffectual, the function was also called unprotected from dataset.py#306, which is what caused the issue in #1116.
Fixes #1116