Allow tasks to be downloaded without dataqualities #1086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously ``download_qualities`` would be left at the default of True with no way to overwrite it.
mfeurer
reviewed
May 19, 2021
PGijsbers
commented
May 20, 2021
| task | ||
| """ | ||
| if not isinstance(task_id, int): | ||
| warnings.warn("Task id must be specified as `int` from 0.14.0 onwards.", DeprecationWarning) |
Collaborator
Author
There was a problem hiding this comment.
Went with (what I remember to be) scikit-learn's default behavior of having at least one full minor release with the deprecation warning.
mfeurer
approved these changes
May 20, 2021
PGijsbers
added a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
* Allow tasks to be downloaded without dataqualities Previously ``download_qualities`` would be left at the default of True with no way to overwrite it. * Deprecate the use of strings for identifying tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
download_qualitieswould be left at the default ofTruewith no way to overwrite it, this PR adds the parameter toget_taskwhich would allow you to download a task with its dataset without ever downloading qualities.