Skip to content

Don't fail when Parquet server can't be reached #1085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mfeurer merged 1 commit into from
May 19, 2021
Merged

Don't fail when Parquet server can't be reached #1085

mfeurer merged 1 commit into from
May 19, 2021

Conversation

@PGijsbers
Copy link
Collaborator

@PGijsbers PGijsbers commented May 19, 2021 •
edited
Loading

Fixes #1084.
The Parquet file is optional, and failing to reach it (and download it)
should not prevent the usage of the other cached/downloaded files.

To test run:

import openml

d = openml.datasets.get_dataset(4135)
print(d)

once with an internet connection, and once without. Both should work.

@PGijsbers
Don't fail when Parquet server can't be reached
8a4af59 
The Parquet file is optional, and failing to reach it (and download it)
should not prevent the usage of the other cached/downloaded files.
PGijsbers
PGijsbers commented May 19, 2021
View reviewed changes
openml/datasets/functions.py
parquet_file = _get_dataset_parquet(description)
try:
parquet_file = _get_dataset_parquet(description)
except urllib3.exceptions.MaxRetryError:
Copy link
Collaborator Author

@PGijsbers PGijsbers May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure if I should be conservative here, or just catch all errors. Considering we haven't had any issues otherwise I went with the general best practice of only minimally catching exceptions.

Copy link
Collaborator

@mfeurer mfeurer May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@PGijsbers PGijsbers requested a review from mfeurer May 19, 2021 09:46
@NeoChaos12 NeoChaos12 mentioned this pull request May 19, 2021
Closed
@mfeurer mfeurer merged commit 0b786e4 into develop May 19, 2021
@mfeurer mfeurer deleted the fix_1084 branch May 19, 2021 15:46
PGijsbers added a commit to Mirkazemi/openml-python that referenced this pull request Feb 23, 2023
@PGijsbers
Don't fail when Parquet server can't be reached (openml#1085)
d3a5516 
The Parquet file is optional, and failing to reach it (and download it)
should not prevent the usage of the other cached/downloaded files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfeurer mfeurer mfeurer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cached datasets unusable without internet access due to missing Parquet files

3 participants

@PGijsbers @mfeurer