doc update #1077
Merged
doc update #1077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfeurer
reviewed
May 12, 2021
Collaborator
mfeurer
left a comment
mfeurer
left a comment
There was a problem hiding this comment.
Hey, could you please have a look at why the unit tests are failing?
| class SklearnExtension(Extension): | ||
| """Connect scikit-learn to OpenML-Python.""" | ||
| """Connect scikit-learn to OpenML-Python. | ||
| The estimators which use this extension must be scikit-learn compatible', |
Collaborator
There was a problem hiding this comment.
Suggested change
| The estimators which use this extension must be scikit-learn compatible', | |
| The estimators which use this extension must be scikit-learn compatible, |
Member
Author
There was a problem hiding this comment.
The doc build is failing due to a broken link error. I checked this with Pieter:
- The link is broken because it's not in the main branch yet. The documentation is here: https://github.com/openml/openml-python/tree/develop/docker
- As soon as the next merge to main happens, the links should work
mfeurer
approved these changes
May 14, 2021
PGijsbers
pushed a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
* doc update * fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
What does this PR implement/fix? Explain your changes.
Change documentation as discussed here #1067
How should this PR be tested?
Any other comments?