Skip to content

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented May 7, 2021

No description provided.

@mfeurer mfeurer requested a review from PGijsbers May 7, 2021 18:52
Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to PyCharm there are many references to master which are not updated. These are in markdown files (contributing, pull request template and readme), .rst files (usage, contributing) and tutorials (e.g. create_upload_tutorial.py). Is that intentional?

@mfeurer
Copy link
Collaborator Author

mfeurer commented May 10, 2021

According to PyCharm there are many references to master which are not updated.

I had a file mask on...PyCharm only showed the files ending with .py...thanks for seeing that and sorry for the incomplete PR, I will update it.

@mfeurer
Copy link
Collaborator Author

mfeurer commented May 12, 2021

Done. I had to replace a link referring to an anchor by a link to an example. I am currently wondering whether we should keep the deep link and ask at the sphinx gallery team how to do this?

README.md Outdated
Master branch:
Main branch:

[![Build Status](https://travis-ci.org/openml/openml-python.svg?branch=master)](https://travis-ci.org/openml/openml-python)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build status and coverage links should also be updated, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and no. We don't have travis-ci any more, so I opted to remove all of them for now.

@PGijsbers PGijsbers self-requested a review May 12, 2021 09:17
Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the links and they all seem to work fine for me. I only have the concern for the badges otherwise it looks good to me.

@mfeurer mfeurer requested a review from PGijsbers May 14, 2021 11:13
@PGijsbers PGijsbers merged commit bb17e72 into develop May 17, 2021
@PGijsbers PGijsbers deleted the rename_master_to_main branch May 17, 2021 08:30
PGijsbers added a commit to Mirkazemi/openml-python that referenced this pull request Feb 23, 2023
* rename master to main

* update changelog

* fix documentation building script

* rename master to main in all remaining docs

* drop badges

Co-authored-by: PGijsbers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants