Skip to content

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Apr 30, 2021

Moves hidden information into a single place.

@mfeurer mfeurer requested review from PGijsbers and janvanrijn April 30, 2021 18:52
Copy link
Collaborator

@PGijsbers PGijsbers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally managed to build the docs :) sorry for the delay.
I think the page still sorely lacks a bit more of a walkthrough for building an extension, though that's out of scope for this PR. I think it's a big improvement to have this more prominently displayed in the docs 👍

@janvanrijn
Copy link
Member

Thanks for approving this (I wasn't able to verify whether the docs build yet)

I will add to this page later this week! (please go ahead with the merge)

@PGijsbers PGijsbers merged commit 968e251 into develop May 4, 2021
@PGijsbers PGijsbers deleted the add_extensions_page branch May 4, 2021 14:23
@mfeurer
Copy link
Collaborator Author

mfeurer commented May 4, 2021

Thanks for approving this (I wasn't able to verify whether the docs build yet)

We build the docs on each commit/PR, but for whatever reason, the job is named build-and-deploy

Looking forward to your PR Jan!

PGijsbers pushed a commit to Mirkazemi/openml-python that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants