Skip to content

Conversation

@Neeratyoy
Copy link
Contributor

What does this PR implement/fix? Explain your changes.

Adding warnings to all documentation examples where the test server is activated in order to serve as a disclaimer to users regarding possible performance/behaviour changes.

@Neeratyoy Neeratyoy requested a review from mfeurer April 21, 2021 15:04
Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a warning via warnings.warn to the function that actives the test server? I know it's basically duplicating the information, but let's better be safe than sorry.

@Neeratyoy
Copy link
Contributor Author

Could you please add a warning via warnings.warn to the function that actives the test server?

Done

@Neeratyoy Neeratyoy requested a review from mfeurer April 22, 2021 16:21
Copy link
Collaborator

@mfeurer mfeurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @PGijsbers what do you think of these warning messages?

@Neeratyoy Neeratyoy requested review from PGijsbers and mfeurer April 28, 2021 14:02
@mfeurer mfeurer merged commit 6e8a9db into develop Apr 29, 2021
@mfeurer mfeurer deleted the add_example_warnings branch April 29, 2021 07:09
github-actions bot pushed a commit that referenced this pull request Apr 29, 2021
PGijsbers pushed a commit to Mirkazemi/openml-python that referenced this pull request Feb 23, 2023
* Adding warnings to all examples switching to a test server

* Creating warnings in new text cells

* Fixing a bug

* Debugging doc build failures

* Update openml/config.py

Co-authored-by: Matthias Feurer <[email protected]>

* Fixing GUI commit bug

* Using a common warning message for docs

* Renaming warning message file

* Editing the non-edited file

Co-authored-by: Matthias Feurer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants