Speed up dataset unit tests #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by only loading necessary datasets
PGijsbers
reviewed
Apr 19, 2021
Collaborator
PGijsbers
left a comment
PGijsbers
left a comment
There was a problem hiding this comment.
Wouldn't it be better to just work with a lazy-load property?
e.g.
self._titanic = None
@property
def titantic(self):
if self._titanic is None:
self._titanic = download..
return self._titanicI guess the fact that it requires less changes is a bit moot at this point, but it does make more use of code re-use (which is more maintainable and less error prone).
This reverts commit 861b52d.
Collaborator
Author
Yes, I agree on code reuse. It'll also be easier if we at one point move to pytest. |
PGijsbers
approved these changes
Apr 21, 2021
Collaborator
PGijsbers
left a comment
PGijsbers
left a comment
There was a problem hiding this comment.
Exactly :) Conversion to fixtures should be no issue at all.
PGijsbers
pushed a commit
to Mirkazemi/openml-python
that referenced
this pull request
Feb 23, 2023
* Speed up dataset unit tests by only loading necessary datasets * Revert "Speed up dataset unit tests" This reverts commit 861b52d. * address suggestions from Pieter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by only loading necessary datasets