Skip to content

Conversation

@mfeurer
Copy link
Collaborator

@mfeurer mfeurer commented Apr 6, 2021

Reference Issue

#1035

What does this PR implement/fix? Explain your changes.

Change sphinx autodoc configuration to use a dictionary instead of a list. I don't know when this was changed in sphinx, but I was able to pin down when this was changed in scikit-learn: scikit-learn/scikit-learn#13982

How should this PR be tested?

Build the docs locally with and without this PR using sphinx >= 3.X (the change isn't necessary for sphinx 2.X)

@PGijsbers
Copy link
Collaborator

Our doc dependencies don't currently specify version identifiers. Should we consider fixing them?

@mfeurer
Copy link
Collaborator Author

mfeurer commented Apr 9, 2021

I just added a minimum version for Sphinx and added this to the progress/what's new page.

@mfeurer mfeurer requested a review from PGijsbers April 9, 2021 08:05
@PGijsbers PGijsbers merged commit 370f64f into develop Apr 9, 2021
@PGijsbers PGijsbers deleted the fix_1035 branch April 9, 2021 08:46
PGijsbers pushed a commit to Mirkazemi/openml-python that referenced this pull request Feb 23, 2023
* change sphinx autodoc syntax

* add minimal sphinx version for doc building
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants