Adding sklearn min. dependencies for all versions #1022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neeratyoy
force-pushed
the
sklearn_min_dep
branch
from
43125ad to
5ea2e72
Compare
Codecov Report
@@ Coverage Diff @@
## develop openml/openml-python#1022 +/- ##
===========================================
- Coverage 88.23% 88.02% -0.21%
===========================================
Files 36 36
Lines 4571 4577 +6
===========================================
- Hits 4033 4029 -4
- Misses 538 548 +10
Continue to review full report at Codecov.
|
mfeurer
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issue
Addresses openml/openml-sklearn#1.
What does this PR implement/fix? Explain your changes.
Allows exact minimum dependency of packages to be listed in a sklearn
flowcreated under thedependenciesattribute.How should this PR be tested?
Doesn't break any existing unit tests.
Any other comments?
Need to assess how existing flows with different
dependencystring is affected.