improve path detection #1021
Merged
improve path detection #1021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1021 +/- ##
===========================================
+ Coverage 88.04% 88.06% +0.02%
===========================================
Files 36 36
Lines 4568 4568
===========================================
+ Hits 4022 4023 +1
+ Misses 546 545 -1
Continue to review full report at Codecov.
|
PGijsbers
approved these changes
Feb 10, 2021
Collaborator
|
It looks like the tests are now leaving files behind: e.g. https://github.com/openml/openml-python/pull/1021/checks?check_run_id=1830686974 |
PGijsbers
requested changes
Feb 11, 2021
Collaborator
PGijsbers
left a comment
PGijsbers
left a comment
There was a problem hiding this comment.
setting to request changes because the issue needs to be looked into.
Collaborator
Author
|
Hm, I don't understand why my change might fix this, but it appears to do so? |
PGijsbers
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue that could make unit tests crashed if the OpenML-Python repository was not in the path. Reported in conda-forge/staged-recipes#13860