Skip to content

Conversation

@Neeratyoy
Copy link
Contributor

Reference Issue

To debug the failing unit tests for PR #982.

What does this PR implement/fix? Explain your changes.

Renames custom flow tutorial to not be executed when creating docs.

How should this PR be tested?

Check if Github Actions for the docs work fine.

@codecov-io
Copy link

codecov-io commented Jan 27, 2021

Codecov Report

Merging #1019 (3e2cbd4) into develop (fba6aab) will increase coverage by 0.53%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1019      +/-   ##
===========================================
+ Coverage    87.62%   88.15%   +0.53%     
===========================================
  Files           36       36              
  Lines         4574     4771     +197     
===========================================
+ Hits          4008     4206     +198     
+ Misses         566      565       -1     
Impacted Files Coverage Δ
openml/extensions/sklearn/__init__.py 83.33% <75.00%> (-16.67%) ⬇️
openml/runs/functions.py 83.20% <100.00%> (+0.29%) ⬆️
openml/testing.py 84.14% <100.00%> (+0.21%) ⬆️
openml/_api_calls.py 89.23% <0.00%> (-3.08%) ⬇️
openml/utils.py 91.33% <0.00%> (+0.66%) ⬆️
openml/datasets/functions.py 94.42% <0.00%> (+0.98%) ⬆️
openml/datasets/dataset.py 88.78% <0.00%> (+4.34%) ⬆️
openml/exceptions.py 96.77% <0.00%> (+9.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba6aab...3e2cbd4. Read the comment docs.

@mfeurer mfeurer changed the base branch from develop to fix_773 January 28, 2021 10:01
@mfeurer mfeurer marked this pull request as ready for review January 28, 2021 10:10
@mfeurer mfeurer merged commit f6aa7ed into fix_773 Jan 28, 2021
@mfeurer mfeurer deleted the debug_custom_flow_docs branch January 28, 2021 10:10
mfeurer added a commit that referenced this pull request Jan 28, 2021
* Adding importable helper functions

* Changing import of cat, cont

* Better docstrings

* Adding unit test to check ColumnTransformer

* Refinements from @mfeurer

* Editing example to support both NumPy and Pandas

* Unit test fix to mark for deletion

* Making some unit tests work

* Waiting for dataset to be processed

* Minor test collection fix

* Template to handle missing tasks

* Accounting for more missing tasks:

* Fixing some more unit tests

* Simplifying check_task_existence

* black changes

* Minor formatting

* Handling task exists check

* Testing edited check task func

* Flake fix

* More retries on connection error

* Adding max_retries to config default

* Update database retry unit test

* Print to debug hash exception

* Fixing checksum unit test

* Retry on _download_text_file

* Update datasets_tutorial.py

* Update custom_flow_tutorial.py

* Update test_study_functions.py

* Update test_dataset_functions.py

* more retries, but also more time between retries

* allow for even more retries on get calls

* Catching failed get task

* undo stupid change

* fix one more test

* Refactoring md5 hash check inside _send_request

* Fixing a fairly common unit test fail

* Reverting loose check on unit test

* Fixing integer type check to allow np.integer

* Trying to loosen check on unit test as fix

* Examples support for pandas=1.2.1

* pandas indexing as iloc

* fix example: actually load the different tasks

* Renaming custom flow to disable tutorial (#1019)

Co-authored-by: Matthias Feurer <[email protected]>
Co-authored-by: PGijsbers <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants