Fix 1013: Store run setup_string
#1015
Conversation
Also moved the test to OpenMLRun, since it mainly tests the OpenMLRun behavior, not a function from openml.runs.functions.
|
Hey, I think the changes are good, but it's really hard to tell given the massive amount of failing unit tests. We have fixed most of them in PR #1000, but it would be great if you could check the changes in |
|
I noticed |
|
I don't see description in the xsd, but there is |
|
Oops. Looks like |
Long pipelines (e.g. gridsearches) could lead to too long setup strings. This prevented run uploads. Also add mypy ignores for old errors which weren't yet vetted by mypy.
|
@mfeurer I think it's done now. Updated the progress log so it doesn't need a separate PR. The |
* Test setup_string is stored and retrievable * Add setup_string to run dictionary representation * Add fix to release notes * Test setup_string in xml without roundtrip Also moved the test to OpenMLRun, since it mainly tests the OpenMLRun behavior, not a function from openml.runs.functions. * Serialize run_details * Update with merged PRs since 11.0 * Prepare for run_details being provided by the server * Remove pipeline code from setup_string Long pipelines (e.g. gridsearches) could lead to too long setup strings. This prevented run uploads. Also add mypy ignores for old errors which weren't yet vetted by mypy.
Closes #1013.