Removes data migration that causes errors during setup#4718
Merged
Conversation
joemull
approved these changes
Apr 18, 2025
Member
|
Merging without a second review since it's a high-priority patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally I tried to fix this migration but realised that there no circumstances under which it will ever work in the future or be useful. The migration was added over two years ago so it has no effect for new installs and anyone still using a version of Janeway that old is very unlikely. The _es setting value will always be missing and it will be skipped or it will error out. We need to decide, for the future, how to handle adding new languages in a safe way or ensure that all migrations will always run. It may be that we need to shift the altering of settings like this out of the migration process all together (although it has proven convenient up until now).
This closes #4632
Once merged we can create a 1.7.5 release.