@alainna I see @bibliotechy has added this to a branch on your fork, can you give us a green tick if you are happy with this solution for #4660

@mauromsl It fixes the immediate problem, but when @alainna approved the new version, it gave a new error

Reverse for 'repository_preprint' with arguments '('',)' not found. 1 pattern(s) tried: ['repository/view/(?P<preprint_id>\\d+)/$']

That same issue does not happen on 1.7.4 without this commit merged in.

@mauromsl It fixes the immediate problem, but when @alainna approved the new version, it gave a new error

Reverse for 'repository_preprint' with arguments '('',)' not found. 1 pattern(s) tried: ['repository/view/(?P<preprint_id>\\d+)/$']

That same issue does not happen on 1.7.4 without this commit merged in.

Can you let me know the url path where this occurs?

@ajrbyers /repository/manager/versions/

Very odd indeed but I’ll try to patch it on Tuesday unless you can work it out.

On the POST to /repository/manager/versions/, it is trying to render this template

"<p><strong>Dear {{ pending_update.preprint.owner.full_name }},</strong></p>\n<p>Thank you for uploading a new version of {{ pending_update.preprint.title }}. This has been approved and is now live: {% if preprint.preprint_doi %} https://doi.org/{{ preprint.preprint_doi }} {% else %} {% site_url 'repository_preprint' preprint.pk %} (Note: A DOI has not yet been minted for this article. Please check your article URL in one hour for the DOI. If no DOI is available after 24 hours, please notify the {{ request.repository.name }} Team. {% endif %} </p>\n<p>{{ request.repository.name }} Team<br>{{ request.repository.site_url }}</p>"

but failing on the site_url template tag https://github.com/openlibhums/janeway/blob/v1.7.4/src/core/templatetags/fqdn.py#L33-L44

I think this might be a problem on your template. When passing the preprint id to repository_preprint it should use pending_update.preprint.pk rather than preprint.pk as preprint isn’t a variable that is available.

@ajrbyers @bibliotechy thanks for the tip! Confirmed: updated the dev "accept/reject version" email templates to match stg and no longer received the error

@mauromsl happy with this?