Fixes issue with repository log view#4649
Merged
ajrbyers merged 1 commit intoMar 7, 2025
Merged
Conversation
The addressee display template was updated to include a check for PII, but the implementation assumes that the item being managed is an article in a journal, but that template fragment is also used by the repository log. Adds some logic to check if the article variable is defined before applying PII checks. This means that PII checks are not appliedd to repository email addresses in this list, but as none of the rest of the PII functionality is built out for repository side, this seems reasonble. Fixes openlibhums#4637
mauromsl
approved these changes
Mar 7, 2025
ajrbyers
approved these changes
Mar 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The addressee display template was updated to include a check for PII, but the implementation assumes that the item being managed is an article in a journal, but that template fragment is also used by the repository log.
Adds some logic to check if the article variable is defined before applying PII checks. This means that PII checks are not appliedd to repository email addresses in this list, but as none of the rest of the PII functionality is built out for repository side, this seems reasonble.
Fixes #4637