Fix #4636 - pre-ticked repo submit agreement#4638
Merged
joemull merged 1 commit intoMar 6, 2025
Merged
Conversation
When a user starts the process for a new repository submission, the box is always pre-ticked. The current code checks if the form model is False, but it is actually an instance of `<class 'repository.models.Preprint'>`. This updates the logic to check if the instance has an id, which it won't is not yest saved to the databse, but it will have an id if is has been saved. Fixes openlibhums#4636
ajrbyers
approved these changes
Mar 1, 2025
joemull
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user starts the process for a new repository submission, the box is always pre-ticked. The current code checks if the form model is False, but it is actually an instance of
<class 'repository.models.Preprint'>. This updates the logic to check if the instance has an id, which it won't if not yest saved to the database, but it will have an id if it has been saved.Fixes #4636