Skip to content

Removes share links from the article page and replaces them with a share link and copy button#4619

Merged
StephDriver merged 4 commits into
masterfrom
b-4390-feat
Feb 14, 2025
Merged

Removes share links from the article page and replaces them with a share link and copy button#4619
StephDriver merged 4 commits into
masterfrom
b-4390-feat

Conversation

@ajrbyers

@ajrbyers ajrbyers commented Feb 12, 2025

Copy link
Copy Markdown
Member
Screenshot 2025-02-12 at 16 53 21 Screenshot 2025-02-12 at 16 53 26 Screenshot 2025-02-12 at 16 53 30

@ajrbyers ajrbyers added this to the v1.8.0 Tracker milestone Feb 12, 2025
@ajrbyers ajrbyers requested a review from mauromsl February 12, 2025 17:16
@mauromsl mauromsl requested a review from StephDriver February 14, 2025 09:31
@mauromsl mauromsl assigned StephDriver and unassigned mauromsl Feb 14, 2025
Comment thread src/themes/OLH/templates/elements/journal/share.html Outdated
Comment thread src/themes/clean/templates/elements/journal/share.html Outdated
Comment thread src/themes/material/templates/elements/journal/share.html Outdated

@StephDriver StephDriver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few A11y tweaks needed

  1. icon syntax (see comments above).
  2. Share link text is a naked DOI, which means this text is read aloud by voiceover, each letter and number separately and only afterwards tells you it is the article share link. i.e. the aria-label is read out after the text itself, not instead of it.

see also #4221 for info on accessible DOI links (I know this isn't a link, but that's because its a special case to provide it as text to copy - I think it should still be read aloud in an understandable format).

@StephDriver StephDriver assigned ajrbyers and unassigned StephDriver Feb 14, 2025
@ajrbyers

Copy link
Copy Markdown
Member Author

A few A11y tweaks needed

1. icon syntax (see comments above).

2. Share link text is a naked DOI, which means this text is read aloud by voiceover, each letter and number separately and only afterwards tells you it is the article share link.  i.e. the aria-label is read out after the text itself, not instead of it.

see also #4221 for info on accessible DOI links (I know this isn't a link, but that's because its a special case to provide it as text to copy - I think it should still be read aloud in an understandable format).

  1. Is now resolved.

@ajrbyers

Copy link
Copy Markdown
Member Author

A few A11y tweaks needed

1. icon syntax (see comments above).

2. Share link text is a naked DOI, which means this text is read aloud by voiceover, each letter and number separately and only afterwards tells you it is the article share link.  i.e. the aria-label is read out after the text itself, not instead of it.

see also #4221 for info on accessible DOI links (I know this isn't a link, but that's because its a special case to provide it as text to copy - I think it should still be read aloud in an understandable format).

  1. is now also updated.

@ajrbyers ajrbyers assigned StephDriver and unassigned ajrbyers Feb 14, 2025
@ajrbyers ajrbyers requested a review from StephDriver February 14, 2025 11:54

@StephDriver StephDriver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks - all three themes tested with voice over and sounding good.

@StephDriver StephDriver merged commit be30135 into master Feb 14, 2025
@StephDriver StephDriver deleted the b-4390-feat branch February 14, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change X/Twitter sharelink to Bluesky

3 participants