Skip to content

Fix a bug on the article page with a misleading downloads metric#4599

Merged
ajrbyers merged 1 commit into
masterfrom
b-4299-downloads-metric-bugfix
Feb 4, 2025
Merged

Fix a bug on the article page with a misleading downloads metric#4599
ajrbyers merged 1 commit into
masterfrom
b-4299-downloads-metric-bugfix

Conversation

@joemull

@joemull joemull commented Jan 29, 2025

Copy link
Copy Markdown
Member

Fixes #4299.

@ajrbyers ajrbyers requested a review from StephDriver January 29, 2025 13:37
@ajrbyers ajrbyers assigned StephDriver and unassigned ajrbyers Jan 29, 2025

@StephDriver StephDriver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joemull
What was the expected behaviour for when there are views, but no downloads?
because this is what I'm seeing:
image
but I thought from the issue, that the downloads part of that would be hidden, so it would just show the views.

@ajrbyers

ajrbyers commented Feb 4, 2025

Copy link
Copy Markdown
Member

@joemull What was the expected behaviour for when there are views, but no downloads? because this is what I'm seeing: image but I thought from the issue, that the downloads part of that would be hidden, so it would just show the views.

It should only hide the Downloads if there are no downloable galleys.

@StephDriver

Copy link
Copy Markdown
Member

It should only hide the Downloads if there are no downloable galleys.

the reasoning given in the original issue is:

Reasoning - having a metric with a zero just looks bad.

So this does seem to apply to cases of nothing yet having been downloaded, so where there are views, but no downloads. However that is a very niche case, as any article with downloads avaliable and that has been viewed, is unlikely to remain on zero for long outside of a development environment! Ok, instead of borrowing trouble, lets go with this and we can always come back later for the other if it does become a user issue.

@StephDriver StephDriver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see comments above, but go ahead!)

@ajrbyers ajrbyers merged commit d9c1ea5 into master Feb 4, 2025
@ajrbyers ajrbyers deleted the b-4299-downloads-metric-bugfix branch February 4, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hide Downloads from Metrics when there are no Downloadable galleys?

3 participants