Skip to content

a11y #4244 keywords markup as lists#4559

Merged
ajrbyers merged 4 commits into
masterfrom
b-4244-update-list-markup
Mar 18, 2025
Merged

a11y #4244 keywords markup as lists#4559
ajrbyers merged 4 commits into
masterfrom
b-4244-update-list-markup

Conversation

@StephDriver

Copy link
Copy Markdown
Member

closes #4244

@StephDriver

This comment was marked as outdated.

@StephDriver StephDriver self-assigned this Dec 20, 2024
@StephDriver

This comment was marked as resolved.

@StephDriver StephDriver force-pushed the b-4244-update-list-markup branch 2 times, most recently from e1cc0b7 to 9031da6 Compare March 10, 2025 09:21
@StephDriver StephDriver marked this pull request as ready for review March 10, 2025 10:23
@StephDriver StephDriver requested a review from joemull March 10, 2025 10:24
@StephDriver StephDriver assigned joemull and unassigned StephDriver Mar 10, 2025

@joemull joemull left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me--there's just a margin-left remaining on the ul element in the references on the OLH theme.

Screenshot from 2025-03-17 18-58-51

Comment thread src/themes/OLH/assets/scss/app.scss
@joemull joemull assigned StephDriver and unassigned StephDriver and joemull Mar 17, 2025
@StephDriver StephDriver force-pushed the b-4244-update-list-markup branch from 18bc37a to 0927b2c Compare March 18, 2025 12:54
@StephDriver StephDriver requested a review from joemull March 18, 2025 12:54
@StephDriver

StephDriver commented Mar 18, 2025

Copy link
Copy Markdown
Member Author

changes made, and PR rebased to remove conflicts too.

@StephDriver StephDriver assigned joemull and unassigned StephDriver Mar 18, 2025
@joemull joemull requested a review from ajrbyers March 18, 2025 13:41
@joemull joemull assigned ajrbyers and unassigned joemull Mar 18, 2025
@ajrbyers ajrbyers merged commit 1df1b31 into master Mar 18, 2025
@ajrbyers ajrbyers deleted the b-4244-update-list-markup branch March 18, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

markup lists as lists on the article page

3 participants