Make sure breadcrumbs only appear when they are useful#4541
Merged
Conversation
ajrbyers
requested changes
Jan 8, 2025
ajrbyers
left a comment
ajrbyers
left a comment
Member
There was a problem hiding this comment.
A bunch of the commits here don't look like they fit with this PR. Can you please take a look?
joemull
force-pushed
the
b-4540-login-breadcrumb
branch
from
a075101 to
ca4782f
Compare
Member
Author
|
Oh, @ajrbyers yeah it was due to the accidental merge of typesetting. I have rebased it now. |
ajrbyers
approved these changes
Jan 8, 2025
StephDriver
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4540