Conversation
ajrbyers
commented
Nov 26, 2024
ajrbyers
commented
Member
- Closes Spelling mistake in journal channel notifications on discord #4507
ajrbyers
changed the title
StephDriver
approved these changes
Nov 26, 2024
StephDriver
left a comment
StephDriver
left a comment
Member
There was a problem hiding this comment.
this does feel very specific, using strings for two possible decisions, despite decisions themselves being defined elsewhere in the code. I am nervous about this for reusability, but it is also very minor so that if this did break it would just read a bit strangely rather than cause a problem.
On principle I'm a bit uncomfortable, but in practice I say just do this and let's all move on to the next thing.
So I approve.
ajrbyers
requested review from
MartinPaulEve
and removed request for
mauromsl
Member
Author
|
I've reassigned this to @MartinPaulEve, I think @mauromsl has a few other reviews on his list ;) |
MartinPaulEve
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.