Removes missed PII from review and revision interfaces#4481
Merged
Conversation
mauromsl
approved these changes
Nov 5, 2024
mauromsl
left a comment
mauromsl
left a comment
Member
There was a problem hiding this comment.
glad to see us leveraging the custom filter further :)
StephDriver
approved these changes
Nov 5, 2024
StephDriver
left a comment
StephDriver
left a comment
Member
There was a problem hiding this comment.
tested and found that:
- both pages reported now show
[anonymised data] - this only applies to the section editor assigned to that article and when the setting is enabled... when not enabled the names are shown, and when setting is enabled but section editor is not assigned to that article (e.g. viewing list of all articles in review) they can see the author name for all other articles.
It is my understanding this is then intended result - that the anonymisation should only be for the assigned articles not across all articles at the review stage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4476