Skip to content

Fixes two issues related to prepublication author and reviewer notifications#4478

Merged
StephDriver merged 2 commits into
r-v1.7.xfrom
4477-bugfix
Nov 5, 2024
Merged

Fixes two issues related to prepublication author and reviewer notifications#4478
StephDriver merged 2 commits into
r-v1.7.xfrom
4477-bugfix

Conversation

@ajrbyers

@ajrbyers ajrbyers commented Nov 4, 2024 •
edited
Loading

Copy link
Copy Markdown
Member
  • If no corresp author is present adds this as a warning
  • When no corresp author is found set author_initial['to'] to None, form validation will handle it being empty
  • The change above surfaced a bug with in article.non_correspondence_authors also fixed by this PR
  • The notification template had additional protection as it checked whether the given article had peer reviews, this was not present in the logic file so posting this form would error due to the second form not being present. This check is now also present in the logic.
  • Shifts prepub warnings into their own file and inseted with an include.
  • Closes Staff cannot send publication notification emails in certain circumstances #4477

@ajrbyers ajrbyers changed the base branch from master to r-v1.7.x November 4, 2024 12:16
@ajrbyers ajrbyers added this to the v1.7.x milestone Nov 4, 2024
@ajrbyers ajrbyers requested a review from mauromsl November 5, 2024 09:55
mauromsl
mauromsl requested changes Nov 5, 2024
View reviewed changes

@mauromsl mauromsl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajrbyers Couple minor comments inline, feel free to pass on to second reviewer if you think they are a non-issue

Comment thread src/submission/models.py
Comment thread src/templates/admin/submission/edit/metadata.html Outdated
@mauromsl mauromsl assigned ajrbyers and unassigned ajrbyers and mauromsl Nov 5, 2024
@ajrbyers ajrbyers requested a review from mauromsl November 5, 2024 10:39
@ajrbyers ajrbyers assigned mauromsl and unassigned ajrbyers Nov 5, 2024
@mauromsl mauromsl assigned StephDriver and unassigned mauromsl Nov 5, 2024
@ajrbyers ajrbyers added the Priority urgent Urgent priority label Nov 5, 2024
StephDriver
StephDriver approved these changes Nov 5, 2024
View reviewed changes

@StephDriver StephDriver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review of code only as per discussion. I have worked through the new logic and that makes sense to me.

@StephDriver StephDriver merged commit 1ec0f39 into r-v1.7.x Nov 5, 2024
@StephDriver StephDriver deleted the 4477-bugfix branch November 5, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephDriver StephDriver StephDriver approved these changes
@mauromsl mauromsl Awaiting requested review from mauromsl

Assignees

@StephDriver StephDriver

Labels

Priority urgent Urgent priority

Projects

None yet

Milestone

v1.7.x

Development

Successfully merging this pull request may close these issues.

Staff cannot send publication notification emails in certain circumstances

3 participants

@ajrbyers @StephDriver @mauromsl