Skip to content

#3965 adds text to the move_to_next modal.#4472

Merged
ajrbyers merged 3 commits into
masterfrom
b-3965
Jan 15, 2025
Merged

#3965 adds text to the move_to_next modal.#4472
ajrbyers merged 3 commits into
masterfrom
b-3965

Conversation

@ajrbyers

@ajrbyers ajrbyers commented Oct 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Member
  • Adds text to explain the current stage and the stage the article will move to.

Closes #3965

Screenshot 2025-01-15 at 09 18 28

Astronaut-resting
Astronaut-resting approved these changes Dec 5, 2024
View reviewed changes

@Astronaut-resting Astronaut-resting left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better!

@ajrbyers ajrbyers requested a review from StephDriver December 5, 2024 16:00
StephDriver
StephDriver approved these changes Dec 6, 2024
View reviewed changes

@StephDriver StephDriver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really like this - far clearer.

StephDriver
StephDriver requested changes Dec 6, 2024
View reviewed changes

@StephDriver StephDriver left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much clearer, but I think the button text should also update to reflect this. Instead of move to next stage, a move to name of next stage and likewise keep in name of current stage

also link to which issue is being closed.

@StephDriver StephDriver assigned ajrbyers and unassigned StephDriver Dec 6, 2024
@ajrbyers ajrbyers requested a review from StephDriver January 8, 2025 11:03
@ajrbyers ajrbyers assigned StephDriver and unassigned ajrbyers Jan 8, 2025
@StephDriver StephDriver requested a review from joemull January 13, 2025 09:23
@StephDriver StephDriver assigned joemull and unassigned StephDriver Jan 13, 2025
@ajrbyers ajrbyers removed the request for review from joemull January 15, 2025 09:19
@ajrbyers ajrbyers assigned ajrbyers and unassigned joemull Jan 15, 2025
@ajrbyers ajrbyers merged commit ae0f616 into master Jan 15, 2025
@ajrbyers ajrbyers deleted the b-3965 branch January 15, 2025 09:19
@joemull

joemull commented Jan 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

@ajrbyers FYI I was planning to review this one since Steph asked me to. She wasn't able to test it out and there was no screenshot here so I was going to test it today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephDriver StephDriver StephDriver approved these changes
+1 more reviewer
@Astronaut-resting Astronaut-resting Astronaut-resting approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ajrbyers ajrbyers

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Edit 'skip stage' pop-up to include current stage and proposed stage.

4 participants

@ajrbyers @joemull @StephDriver @Astronaut-resting