Skip to content

The clean theme carousel now includes a link bringing it in line with other themes#4466

Merged
StephDriver merged 2 commits into
masterfrom
b-clean-carousel-caption-link
Nov 5, 2024
Merged

The clean theme carousel now includes a link bringing it in line with other themes#4466
StephDriver merged 2 commits into
masterfrom
b-clean-carousel-caption-link

Conversation

@ajrbyers

Copy link
Copy Markdown
Member

Adds a link to the clean theme's carousel.

Screenshot 2024-10-28 at 10 25 51

Keeps styling inline with other links which _are_ underlined.
@ajrbyers ajrbyers requested a review from mauromsl October 28, 2024 10:26
@ajrbyers ajrbyers added the enhancement Add or improve something on an existing feature label Oct 28, 2024
@ajrbyers ajrbyers added this to the v1.7.x milestone Nov 5, 2024
@mauromsl mauromsl requested a review from StephDriver November 5, 2024 11:36
@mauromsl mauromsl assigned StephDriver and unassigned mauromsl Nov 5, 2024
@mauromsl mauromsl added the Priority urgent Urgent priority label Nov 5, 2024

@StephDriver StephDriver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

links yes, CSS - can't get it working. Could be my end. But needs checking before this is merged.

Comment thread src/themes/clean/assets/css/clean.css
@StephDriver StephDriver assigned ajrbyers and unassigned StephDriver Nov 5, 2024
@StephDriver StephDriver self-requested a review November 5, 2024 13:01

@StephDriver StephDriver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passed further testing.

@StephDriver StephDriver merged commit 87bc680 into master Nov 5, 2024
@StephDriver StephDriver deleted the b-clean-carousel-caption-link branch November 5, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Add or improve something on an existing feature Priority urgent Urgent priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants