Make display of funding info clearer on article page#4464
Merged
Conversation
joemull
force-pushed
the
b-4461-funder-link-bugfix
branch
from
1bf11de to
dd0160e
Compare
joemull
force-pushed
the
b-4461-funder-link-bugfix
branch
from
db3bc64 to
2cc1ebd
Compare
ajrbyers
approved these changes
Oct 25, 2024
ajrbyers
left a comment
ajrbyers
left a comment
Member
There was a problem hiding this comment.
See comment on view. Otherwise this is a good approach.
ajrbyers
approved these changes
Oct 25, 2024
StephDriver
approved these changes
Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4461.
See my comment on the original issue for a diagnosis: #4461 (comment)
To make the behavior clear and still display the various IDs for metadata purposes, I have laid out the data using a definition list. I have opted to use the
key_value_abovetemplate from the back office as it is agnostic of styling. If crossing between the themes in this way is undesirable, I can movekey_value_aboveto common templates.