Ensures that active reviews count is accurate#4450
Merged
Conversation
mauromsl
requested changes
Dec 5, 2024
Member
Author
|
I did some investigating here. We need to ensure that assignments where the reviewers decision was not accept are filtered out of the subquery. |
StephDriver
approved these changes
Feb 20, 2025
mauromsl
requested changes
Feb 20, 2025
mauromsl
approved these changes
Feb 21, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new completed reviews manager and tidies up the display of review information when assigning reviewers or looking a their histories.
Example:
Previously this user would have shown multiple active reviews and the review that was withdrawn would be the latest completed date/time.
Closes #4392