When attempting to fetch an image for a NewsItem that does not exist a 404 not found error is now returned#4439
Conversation
StephDriver
left a comment
There was a problem hiding this comment.
I've tested this, and compared to master I can see the change and it works but I have found some strange behaviour:
- This will return a 404 if the news ID doesn't exist.
- This will return a 404 if the news ID exists and there is no image for that item.
- But if there is an image, and you type in a different image number to the one associated with the image in the source of the News Item page, it will still access the image and not 404. Master behaves the same, so this is not introducing a new issue.
So - if the PR is just about non-existent news ID, then I think it does what it is supposed to do, but if it is about non-existent images, then it doesn't because it allows any image number as if it were the correct one as long as the news ID is correct.
e.g.
if image is at: news/id/699/image/166081/
Then news/id/69/image/166081/ will 404 (assuming no other item 69 exists)
But news/id/699/image/166/ will still access the image as if it were news/id/699/image/166081/
I am approving this but leaving it up to the originator to consider the above and decide whether it is working as intended or not, or whether that is a separate issue etc.
|
@StephDriver I'm going to take this one back. It looks like the view has changed the way it operates at some point so there are some superflous arguments. |
|
@StephDriver I've gone over this and these superflous attributes are there to work with the generic carousel URL pattern (one that can work for a news item, issue or article) so I think this is fine. |
|
Added @mauromsl for second review. |
NewsItemthat does not exist.