Skip to content

Updates citation style label text to make it consistent#4430

Merged
ajrbyers merged 5 commits into
masterfrom
b-#4214_tiny_readability_fixes
Oct 30, 2024
Merged

Updates citation style label text to make it consistent#4430
ajrbyers merged 5 commits into
masterfrom
b-#4214_tiny_readability_fixes

Conversation

@StephDriver

Copy link
Copy Markdown
Member

closes #4214

Most of these were already fixed elsewhere or found to be user content (see notes on the issue itself). This left two very minor fixes.

@joemull joemull left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to these changes but they need to be done consistently across the codebase. We have quite a few templates and also translation files that will need updating.

I did a ripgrep search for related language to find these places (see attached files).

Citation.txt
Downloads.txt

@joemull

joemull commented Oct 3, 2024

Copy link
Copy Markdown
Member

Happy to help with editing the .po files--it's something I need to get better at as well, and I don't think we have any documented best practices for when we edit them and when we submit new translations.

@joemull joemull assigned StephDriver and unassigned joemull Oct 3, 2024
@StephDriver

Copy link
Copy Markdown
Member Author

Thanks @joemull - yes please regarding .po files.

In regards to Downloads -> Download Articles, I would prefer to leave this as it is here. This is about contextual headings, so unlike the grammar one cannot be generalised to other files by a search. This issue was specifically to fix that isntance as it had already been identified, but further instances of anything similar will be picked up for the front of house in #4232 (already on there for the general fix contextual headings)

In regards lower case following hyphen when used for citation styles, e.g. Harvard-Style -> Harvard-style, I have added another commit which handles all the remaining instances other than inside the .po files.

To do:

  • Work together to edit the .po files.

@StephDriver StephDriver marked this pull request as draft October 4, 2024 11:00
@joemull joemull removed their assignment Oct 17, 2024

@joemull joemull left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steph and I discussed the change from Downloads to Download Article and decided to revert it so that we can handle this label more consistently across themes in a later issue, perhaps as a part of #4229.

@StephDriver StephDriver marked this pull request as ready for review October 25, 2024 10:37
@StephDriver StephDriver requested a review from joemull October 25, 2024 10:37
@StephDriver StephDriver assigned joemull and unassigned StephDriver Oct 25, 2024
@joemull joemull requested a review from ajrbyers October 30, 2024 11:19
@joemull joemull assigned ajrbyers and unassigned joemull Oct 30, 2024
@ajrbyers ajrbyers merged commit 1cc95e9 into master Oct 30, 2024
@ajrbyers ajrbyers deleted the b-#4214_tiny_readability_fixes branch October 30, 2024 11:25
@ajrbyers ajrbyers changed the title B #4214 tiny readability fixes Update citation style label text to make it consistent Nov 19, 2024
@ajrbyers ajrbyers changed the title Update citation style label text to make it consistent Updates citation style label text to make it consistent Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tiny readability fixes arising from a11y audit

3 participants