These changes seem to make ArticleInfo into an abstract base, but we do not explicitly say that anywhere that I can tell. Can we document it as that, so we don't use it by itself anywhere later?

We should also change this test to use the new class, right?

janeway/src/submission/tests.py

Lines 406 to 419 in 9051b5f

	def test_edit_section(self):
	""" Ensures editors can select sections that are not submissible"""
	article = models.Article.objects.create(
	journal=self.journal_one,
	title="Test article: a test of sections",
	)
	with translation.override("en"):
	section = models.Section.objects.create(
	journal=self.journal_one,
	name="section",
	public_submissions=False,
	)
	form = forms.ArticleInfo(instance=article)
	self.assertTrue(section in form.fields["section"].queryset)

FYI: I don't think we should change the tests, the behaviour is still implemented in ArticleInfo and thus, it is the correct class member to run the test on.

The current abstraction is a bit leaky (why does ArticleInfo take a special argument called editor_view if we already have EditorArticleInfoSubmit)

@ajrbyers my suggestion would be to raise a separate issue to fix the abstraction here but for the sake of this feature, don't refactor these forms just yet.

@joemull are you happy with @mauromsl's suggestion above?

@joemull are you happy with @mauromsl's suggestion above?

Yes, as long as we document it by putting a docstring on the class or opening a new issue.