Adds option to hide personally identifiable information from section editors before review is complete enabling triple anonymous review.#4416
Merged
Conversation
Logic is moved to a helper function.
ajrbyers
changed the title
joemull
requested changes
Sep 25, 2024
joemull
left a comment
joemull
left a comment
Member
There was a problem hiding this comment.
Seems to be working well generally. Got a few comments in the code, and I'll paste screenshots of the two spots I found where PII is still coming through:
joemull
requested changes
Sep 25, 2024
joemull
left a comment
joemull
left a comment
Member
There was a problem hiding this comment.
Here are a few more spots now that I'm loading the right builtin template filters:
joemull
requested changes
Sep 25, 2024
Member
Author
|
I've added the additional fields to the tests, which are passing. Will now start working on docs for this: #4426 |
mauromsl
approved these changes
Sep 26, 2024
joemull
approved these changes
Sep 26, 2024
ajrbyers
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4417
This pull request adds a new security decorator and two new template tags that allow us to hide PII before an article has completed the review stage. Underlying email templates also use this to hide PII in emails.
Note: the custom reply-to setting is mandatory for this feature to work properly as outlined in the pii setting help text
Settings
A new setting
se_pii_filteris introduced to enable or disable this feature.Django Templates
During unassigned and review we hide all author data
Log information is reduced
Document management is locked
Email Templates
Accept, decline, revision and revisions complete templates have all been updated
Emails
The revisions complete email now sets the custom reply to kwarg to ensure the author's email wont leak to the editor.