Reverts account and frozen author fields to charfields.#4406
Merged
Conversation
mauromsl
approved these changes
Sep 13, 2024
mauromsl
left a comment
mauromsl
left a comment
Member
There was a problem hiding this comment.
Thanks! just one minor comment but passing on to Joe to comment on
| <a href="{{ settings.ORCID_URL }}?client_id={{ settings.ORCID_CLIENT_ID }}&response_type=code&scope=/authenticate&redirect_uri={% orcid_redirect_uri 'register' %}" class="button expanded orcid-button">{% trans "Register with ORCiD" %}</a> | ||
| <a | ||
| href="{{ settings.ORCID_URL }}?client_id={{ settings.ORCID_CLIENT_ID }}&response_type=code&scope=/authenticate&redirect_uri={% orcid_redirect_uri 'register' %}" | ||
| class="{{ button_classes }}"> |
Member
There was a problem hiding this comment.
should we set orcid-button as the default if nothing is provided?
Member
Author
There was a problem hiding this comment.
Added a commit with default.
joemull
requested changes
Sep 13, 2024
joemull
left a comment
joemull
left a comment
Member
There was a problem hiding this comment.
I'll go ahead and request the changes we discussed offline so I know when it's ready to review again.
joemull
approved these changes
Sep 18, 2024
joemull
left a comment
joemull
left a comment
Member
There was a problem hiding this comment.
I like using a field validator for this--clean and reproducible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts changes to Account and FrozenAuthor models, returning them to CharFields. There are three reasons for this:
This PR also adds a
button_classesvariable toorcid_registration.htmlso that each theme can style the button with the correct classes.ORCID button after:
