Adds support for repository sitemaps.#4398
Merged
Merged
Conversation
mauromsl
approved these changes
Sep 11, 2024
Comment on lines
+84
to
+96
| if request.journal is not None: | ||
| # if there's a journal, then we render the _journal_ sitemap, not the press | ||
| return journal_views.sitemap(request) | ||
|
|
||
| if request.repository is not None: | ||
| # if there is a repository we return the repository sitemap. | ||
| return repository_views.repository_sitemap(request) | ||
| if request.repository is not None: | ||
| # if there is a repository we return the repository sitemap. | ||
| return repository_views.sitemap(request) | ||
|
|
||
| return files.serve_sitemap_file(['sitemap.xml']) | ||
| except FileNotFoundError: | ||
| logger.warning('Sitemap for {} not found.'.format(request.press.name)) | ||
| raise Http404() | ||
|
|
||
| return core_views.sitemap( | ||
| request, | ||
| ['sitemap.xml'], | ||
| ) |
Member
There was a problem hiding this comment.
I'm thinking it makes more sense for core to redirect to the correct site type of press/journal/repository, to avoid the interdependence between the. That said, it does not currently present a circular import and Press already knows about journal and repository, so I'll leave this as an optional comment
joemull
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3555