Skip to content

Fixed an issue with middle names and added support for page ranges in RIS and BIB exports (zotero, endnote, etc)#4385

Merged
ajrbyers merged 2 commits into
masterfrom
3771-citation_export_update
Sep 6, 2024
Merged

Fixed an issue with middle names and added support for page ranges in RIS and BIB exports (zotero, endnote, etc)#4385
ajrbyers merged 2 commits into
masterfrom
3771-citation_export_update

Conversation

@ajrbyers

@ajrbyers ajrbyers commented Sep 3, 2024

Copy link
Copy Markdown
Member

Updates RIS and BIBTEX with additional information and

@ajrbyers ajrbyers requested a review from mauromsl September 3, 2024 16:31
@mauromsl mauromsl changed the title #3771 adding updates to bibtex and ris templates. Fixed an issue with middle names and added support for page ranges in RIS and BIB exports (zotero, endnote, etc) Sep 4, 2024
@mauromsl mauromsl requested a review from joemull September 4, 2024 15:06
@ajrbyers ajrbyers requested review from StephDriver and joemull and removed request for joemull September 4, 2024 15:11
@ajrbyers ajrbyers assigned StephDriver and unassigned mauromsl Sep 4, 2024
Comment thread src/submission/models.py
Comment on lines +1402 to +1405
def bibtex_author_list(self):
return " and ".join(
[author.full_name() for author in self.frozen_authors()],
)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the spec recommends "AND" (all uppercase) as the separator : https://bibtex.eu/fields/author/

@mauromsl mauromsl assigned ajrbyers and unassigned StephDriver Sep 4, 2024
@ajrbyers ajrbyers requested a review from mauromsl September 4, 2024 15:18
@ajrbyers ajrbyers assigned mauromsl and unassigned ajrbyers Sep 4, 2024
@mauromsl mauromsl assigned StephDriver and unassigned mauromsl Sep 4, 2024

@StephDriver StephDriver left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all seems logical - I've added a single observation but it is on something at the edge of my knowledge so it may well not require any action. Please review the observation and judge whether changes are needed, I'm approving this so that it can just go through assuming changes are not required.

{% load settings %}
{% load encoding %}
{% if article.journal.is_conference %}@conference{% else %}@article{% endif %}{% templatetag openbrace %}{{ article.journal.code }} {{ article.id }},
author = {{ article.author_list|latex_conform }},

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 3 has me puzzled, could well be my lack of understanding, but here's my observation. Please ignore if it a misunderstanding or not relevant:

I read this as a change from an output described by templatetag openbrace journal.article.code articleid, to templatetag openbrace journalarticle.codearticleid, -> i.e. that the last two terms have been concatenated because the space between them has been removed.

Was that intended?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking as changes requested only in as far as asking you to consider this observation before merging.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the space makes thie field invalid.

@StephDriver StephDriver assigned ajrbyers and unassigned StephDriver Sep 6, 2024
@ajrbyers ajrbyers merged commit 0867e20 into master Sep 6, 2024
@ajrbyers ajrbyers deleted the 3771-citation_export_update branch September 6, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Citation export BibTeX citation export does not produce valid BibTeX because of a stray space

3 participants