4353 article page sharelinks a11y update#4355
Conversation
StephDriver
force-pushed
the
4353-article-page-sharelinks-a11y-update
branch
from
e457555 to
1a037ac
Compare
mauromsl
left a comment
mauromsl
left a comment
There was a problem hiding this comment.
Thanks @StephDriver, a small comment on the use of !important and how it might impact theme styling overrides.
| color: var(--twitter-hover) !important; | ||
| } | ||
|
|
||
| .twitter-bg:hover { | ||
| background-color: var(--twitter-hover); | ||
| color: var(--twitter) !important; | ||
| } |
There was a problem hiding this comment.
If we are adding explicit !important colours to the 𝕏 button we should probably do the same for other ones. If not, we will introduce inconsistency wherever someone has overriden btn colours.
Alternatively, do not use the !important property, though I bet you are using because the changes wouldn't take effect on the base theme styling otherwise.
There was a problem hiding this comment.
Yes, you're right, they wouldn't work without !important and very good point, about consistency too.
There was a problem hiding this comment.
hover.mov
While updating, I also realised that the X button inverting on hover was different to the other two buttons - their hover action was a very very subtle change of colour. So I updated all three to the invert behaviour.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
4 participants
Updated the share links across all themes for a11y.
NB the share links for Clean are buttons because of the need to meet WCAG minimum target size. More comments on this with screenshots on issue itself.
Closes #4353
which encompassed these, so it also:
Closes #3933
Closes #4340
Closes #1863